Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
conflicts |
|
@macroscope-app review this |
|
bug with cursor moving to the end when inserting a mention at the start: |
Let me fix this |
|
conflcits |
What Changed
Fixed
@file/folder mentions in the message box.@mentions only worked at the end of the message.@mention in the same message.@could show old search results from the previous mention for the same message.Why
Previously:
@mentions could behave differently depending on where they were typed in the sentence.@could fail or behave inconsistently.@could show stale results from the previous search instead of starting clean for the same message.Now:
@mentions work more reliably anywhere in the message.@starts from a clean suggestion state and only shows current matches.UI Changes
None
Checklist
This PR fixes the issue #857
Note
Fix mention ping detection by using expanded cursor for @-token trigger resolution
detectComposerTriggerFromSnapshotin composer-logic.ts to use the editor'sexpandedCursorwhen available, fixing trigger detection when revisiting @-tokens whose visual width differs from text length.ComposerPromptEditorInnerto track and emit anexpandedCursorthat reflects mention nodes' full text length, propagating it throughonChangeandreadSnapshot.resolveComposerPathMenuEntriesin composer-path-menu.ts to suppress path menu entries when the query is empty, debouncing, or while a fetch is in progress.Macroscope summarized 4ef19c3.