Property with #[Inject] attribute is initialized#133
Open
mabar wants to merge 1 commit intophpstan:1.1.xfrom
Open
Property with #[Inject] attribute is initialized#133mabar wants to merge 1 commit intophpstan:1.1.xfrom
mabar wants to merge 1 commit intophpstan:1.1.xfrom
Conversation
Contributor
|
@mabar it's because of installing nette/di in lowest version (3.0.0) where the class Nette\DI\Attributes\Inject doesn't exist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for inject attributes https://doc.nette.org/en/best-practices/inject-method-attribute#toc-inject-attributes
I am a bit stuck on why the test is failing - same code with native ReflectionProperty works just fine https://3v4l.org/3HF1T
Also my usual primitive debugging methods don't work as usual - var_dump() in tested code makes it stuck indefinitely and e.g.
\PHPUnit\Framework\assertFalse(true)in tested code does not make the test failFor the phpstan failure - should I just add it to ignored? Class does not have to exist in this case.