Fix formatter spacing for JSON path operators (->, ->>)#637
Open
Sea-n wants to merge 1 commit intophpmyadmin:masterfrom
Open
Fix formatter spacing for JSON path operators (->, ->>)#637Sea-n wants to merge 1 commit intophpmyadmin:masterfrom
Sea-n wants to merge 1 commit intophpmyadmin:masterfrom
Conversation
Author
|
CC @MauricioFauth and @williamdes, |
- Treat `->` and `->>` as SQL operators in the lexer.
- Prevent formatter from inserting spaces around JSON path operators.
- Add formatter test for JSON path access.
For example:
```sql
SELECT
details->'$."first_name"'
FROM
users;
```
Signed-off-by: Sean Wei <me@sean.taipei>
williamdes
approved these changes
Jan 21, 2026
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
This looks okay, thank you for adding a test
I will wait for another review from anyone else
Author
|
Ping @MauricioFauth again, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
->and->>as SQL operators in the lexer.For example:
SELECT details->'$."first_name"' FROM users;Expected:
Actual:
Caused SQL syntax error.
Tests
./vendor/bin/phpunitpassedI didn’t run
./vendor/bin/phpcbfas suggested in CONTRIBUTING.md because it currently changes about 60 files and produces roughly 150 lines of diff. If you’re okay with it, I’d love to handle that in a separate PR.References