Skip to content

feat(*):Refactor ComposerIntegrationHandler to streamline installer creation and execution#502

Closed
VinchanGit wants to merge 1 commit intophp:1.4.xfrom
VinchanGit:1.4.x
Closed

feat(*):Refactor ComposerIntegrationHandler to streamline installer creation and execution#502
VinchanGit wants to merge 1 commit intophp:1.4.xfrom
VinchanGit:1.4.x

Conversation

@VinchanGit
Copy link
Contributor

…reation and execution

@asgrim asgrim self-requested a review February 5, 2026 06:54
Copy link
Contributor

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined not to merge this, what is this achieving apart from just moving stuff around? This isn't a feature, unless I missed something...?

@VinchanGit VinchanGit closed this Feb 5, 2026
@asgrim
Copy link
Contributor

asgrim commented Feb 5, 2026

@VinchanGit next time I suggest please make a discussion before doing the work to change things, to make sure it is worth doing :) I don't like wasting people's time, so worth checking beforehand 👍 thank you!

@VinchanGit
Copy link
Contributor Author

@VinchanGit下次如果要改动什么,我建议先讨论一下,确保值得去做 :) 我不喜欢浪费大家的时间,所以最好事先确认一下 👍 谢谢!

I would like to participate in the development of this project. How can I contact you? WhatApp or Telegram?

@asgrim
Copy link
Contributor

asgrim commented Feb 6, 2026

If there is an existing issue, please comment, if not, please make a discussion thread.

The PHP Foundation is currently actively developing this project, so there are a lot of changes already taking place. By submitting PRs without discussing first, you are potentially duplicating work. I really don't want you to be wasting your time.

@VinchanGit
Copy link
Contributor Author

如果存在问题,请留言;如果没有,请发帖讨论。

PHP 基金会目前正在积极开发这个项目,所以已经有很多改动正在进行中。如果您在未事先沟通的情况下提交 PR,可能会造成重复工作。我真的不想让您浪费时间。

ok, get it , thinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants