Open
Conversation
asgrim
commented
Jan 26, 2026
5 tasks
asgrim
force-pushed
the
436-prepackaged-binary-exts
branch
2 times, most recently
from
74b9986 to
22ac08d
Compare
asgrim
force-pushed
the
436-prepackaged-binary-exts
branch
from
22ac08d to
e254033
Compare
…ackaged-binary and a bunch of tests to be implemented
It seems that directly copying the new .so over the old one is slightly
different to rm the old .so then copying the new one. This fixes a segfault
that was observed when an existing ext was already in the ext directory. This
didn't manifest before, because `make install` (the approach used by compiling
from source) uses basically:
$extSrcPath/build/shtool --debug install -c {$extSrcPath}modules/* $dest
This is a shell script, and ultimately it boils down to:
- cp (or mv) the .so to a temp file in the dest path
- rm the dest file
- mv the temp file to the dest file
It was observed that this approach did not cause the segfault, but previous to
this commit, PIE was only doing:
- cp the .so to the dest file
It seems there is some much lower-level differences in how these operations
affect the running processes, so this commit changes PIE to `rm` the target
file if it already exists first, which seems to solve the issue.
asgrim
force-pushed
the
436-prepackaged-binary-exts
branch
from
04a791f to
ae7ae40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #436