Audit zend_ini_string() and related functions#21146
Open
Girgias wants to merge 6 commits intophp:masterfrom
Open
Audit zend_ini_string() and related functions#21146Girgias wants to merge 6 commits intophp:masterfrom
Girgias wants to merge 6 commits intophp:masterfrom
Conversation
Girgias
force-pushed
the
ini-audit-zend_ini_string
branch
from
2e7ae31 to
58f9395
Compare
Girgias
force-pushed
the
ini-audit-zend_ini_string
branch
from
58f9395 to
5095e2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflicts with #21143
I audited the usage of
zend_ini_string()and co as I believe these functions should return aconst char*because they point to a pointer owner by azend_string *.The two other things I am wondering is
INI_STR()macro as it doesn't follow the usual convention of "string" being achar*and "str" meaning azend_string*.INI_ORIG_*macros as they seem mostly pointless?