standard: Validate sort_type argument in array_unique()

[arshidkv12]

The array_unique() now validates the sort_type argument and throws ValueError when an unsupported value is provided.

[iluuu1994]

It looks like this is also missing handling for SORT_FLAG_CASE, which looks to be untested. https://3v4l.org/dqSln This is just from a very quick look, there might be other issues.

[iluuu1994]

Marking as "Request changes" for visibility.

[arshidkv12]

It looks like this is also missing handling for SORT_FLAG_CASE, which looks to be untested. https://3v4l.org/dqSln This is just from a very quick look, there might be other issues.

I don’t see SORT_FLAG_CASE on https://www.php.net/manual/en/function.array-unique.php.

[iluuu1994]

It's not documented, but it's there, as demonstrated by the 3v4l.

[iluuu1994]

That's all the issues I could find. Please somebody else verify. I'm not code owner.

[iluuu1994]

There's also SORT_NATURAL. I don't know whether it would differ in behavior from SORT_STRING, but even if it doesn't it should continue to be accepted.

[arshidkv12]

It works with sort_type & ~PHP_SORT_FLAG_CASE only in php_get_data_compare_func_unstable.

Ref:
https://github.com/php/php-src/blob/master/ext/standard/array.c#L495-L556

[Girgias]

I wonder if it doesn't make more sense to handle this error in php_get_data_compare_func_unstable() (and possibly the related functions)` to also deal with invalid flags for all the sort functions.

[arshidkv12]

@Girgias array_multisort() already checks the sort flags while parsing arguments in ext/standard/array.c, before calling the compare-function selector, so invalid flags are handled at the user-facing level.

Ref:
https://github.com/php/php-src/blob/master/ext/standard/array.c#L6021-L6025

[Girgias]

@arshidkv12 array_multisort() is a very strange function that doesn't follow "usual" PHP userland semantics, so I wouldn't look at that function for how to implement something.