Merged
Conversation
Contributor
|
Nice, but we'll have to fix the CI. Can you do a few things?
|
Contributor
Author
|
OK, but later today. |
Contributor
|
Better! You got the tests to pass, that's awesome. Any chance you can sort out the phpstan and php-cs-fixer issues? If not, no big deal, I can figure them out later. |
Contributor
Author
|
Probably best if you do it, as you know the code better. Also you should upgrade to PHPStan V2. Thanks |
Contributor
|
I put the style workflow back on PHP 8.3 (php-cs-fixer doesn't support 8.4 yet), and fixed the PHPStan issues (I don't have the energy to try out v2 right now), and everything appears to be green. |
Contributor
|
Thanks very much! Keep 'em coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simply ran vendor\bin\php-cs-fixer fix
This automatically will convert to PHP 8.4 to fix this error (and all the others):
Deprecated: ActiveRecord\Table::insert(): Implicitly marking parameter $sequence_name as nullable is deprecated, the explicit nullable type must be used instead in vendor\php-patterns\activerecord\lib\Table.php on line 411
Please merge. Thanks