fixing wrong-key-association bug #119

[geek-at]

No description provided.

[shmax]

Looking good, but before we proceed please update the tests (and make sure they all pass).

[geek-at]

Never written any tests but the existing ones shold be green now

[shmax]

The old tests pass, but since our goal here is to provide some formal support for has_and_belongs_to_many, I think it would be a good idea to add a test suite for it (maybe look at hasManyThroughTest.php for inspiration). To tell you the truth, even I don't know how the feature really works, and some tests would help document and illustrate the functionality. There are also some style errors, and some PHP stan issues. Be sure to run these from your CLI:

composer stan
composer style-check

And if you want to run the tests locally, it's super easy if you have Docker installed locally. Have a look at contributing.md for more details!

[geek-at]

Thanks for the Info! At the moment I don't have the time to look into it so I made a fork with the fix and use that as the package for my project. Might come back for the tests when I have more time.

all the best to you

[shmax]

Oh, that's a shame, I was really looking forward to this new feature. Tell you what: let me know if your change seems stable in your own environment, and if it is I may see if I can spruce up this PR.

[shmax]

I believe this was resolved in this issue:
#124