-
Notifications
You must be signed in to change notification settings - Fork 41
[FEATURE] Add Splunk datasource plugin #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d37ccf8 to
756a791
Compare
splunk/cue.mod/module.cue
Outdated
| kind: "git" | ||
| } | ||
| deps: { | ||
| "github.com/perses/perses/cue@v0": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package was moved. Older package still works but it will be removed in the future
| "github.com/perses/perses/cue@v0": { | |
| "github.com/perses/shared/cue@v0": { |
splunk/cue.mod/module.cue
Outdated
| @@ -0,0 +1,13 @@ | |||
| module: "github.com/perses/plugins/splunk@v0" | |||
| language: { | |||
| version: "v0.14.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| version: "v0.14.0" | |
| version: "v0.15.1" |
splunk/cue.mod/module.cue
Outdated
| } | ||
| deps: { | ||
| "github.com/perses/perses/cue@v0": { | ||
| v: "v0.53.0-beta.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| v: "v0.53.0-beta.3" | |
| v: "v0.53.0-rc.1" |
| package model | ||
|
|
||
| import ( | ||
| "github.com/perses/perses/cue/common" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "github.com/perses/perses/cue/common" | |
| "github.com/perses/shared/cue/common" |
|
|
||
| import ( | ||
| "github.com/perses/perses/cue/common" | ||
| commonProxy "github.com/perses/perses/cue/common/proxy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| commonProxy "github.com/perses/perses/cue/common/proxy" | |
| commonProxy "github.com/perses/shared/cue/common/proxy" |
| "build-mf": "rsbuild build", | ||
| "build:cjs": "swc ./src -d dist/lib/cjs --strip-leading-paths --config-file ../.cjs.swcrc", | ||
| "build:esm": "swc ./src -d dist/lib --strip-leading-paths --config-file ../.swcrc", | ||
| "build:types": "tsc --project tsconfig.build.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint command is missing. This was added recently to the templates.
| "build:types": "tsc --project tsconfig.build.json", | |
| "build:types": "tsc --project tsconfig.build.json", | |
| "lint": "eslint src --ext .ts,.tsx", |
splunk/package.json
Outdated
| "@perses-dev/components": "^0.53.0-beta.3", | ||
| "@perses-dev/core": "^0.53.0-beta.3", | ||
| "@perses-dev/plugin-system": "^0.53.0-beta.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@perses-dev/components": "^0.53.0-beta.3", | |
| "@perses-dev/core": "^0.53.0-beta.3", | |
| "@perses-dev/plugin-system": "^0.53.0-beta.3", | |
| "@perses-dev/components": "^0.53.0-rc.1", | |
| "@perses-dev/core": "^0.53.0-rc.1", | |
| "@perses-dev/plugin-system": "^0.53.0-rc.1", |
splunk/go.mod
Outdated
|
|
||
| go 1.25.1 | ||
|
|
||
| require github.com/perses/perses v0.53.0-beta.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| require github.com/perses/perses v0.53.0-beta.3 | |
| require github.com/perses/perses v0.53.0-rc.0 |
756a791 to
7997593
Compare
AntoineThebaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUE review following a change on main branch:
| commonProxy "github.com/perses/shared/cue/common/proxy" | ||
| ) | ||
|
|
||
| kind: "SplunkDatasource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| datasource?: { | ||
| kind: "SplunkDatasource" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please check how to improve this query schema to ensure it's compatible with the DatasourceVariable plugin https://github.com/perses/plugins/pull/540/changes#diff-6f1afe7036188e8a850133c2bbb0e495ec791fc97629478bb7581e291a7e916a
| datasource?: { | ||
| kind: "SplunkDatasource" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please check how to improve this query schema to ensure it's compatible with the DatasourceVariable plugin https://github.com/perses/plugins/pull/540/changes#diff-6f1afe7036188e8a850133c2bbb0e495ec791fc97629478bb7581e291a7e916a
37be2c4 to
2ec9a89
Compare
Signed-off-by: Sharan Gokul <sharangokul@gmail.com>
2ec9a89 to
7b2c6f5
Compare
Description
The Splunk plugin enables Perses to connect to Splunk instances and query data using Splunk Processing Language (SPL). It supports both time series visualizations and log queries.
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes