Add proper assertions to incomplete tests#6
Merged
arminsabouri merged 2 commits intopayjoin:masterfrom Mar 2, 2026
Merged
Conversation
Previously, several tests had missing or inadequate assertions either using println for debugging instead of validation.
arminsabouri
requested changes
Mar 2, 2026
Collaborator
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Just had one comment. Otherwise looks great.
src/lib.rs
Outdated
| "Missed payment obligations percentage: {:?}", | ||
| result.precentage_of_payment_obligations_missed() | ||
|
|
||
| // Assert reasonable missed percentage (adjust threshold as needed) |
Collaborator
There was a problem hiding this comment.
This assertion is just checking that we have a valid precentage. It should be determenistic.
Can we just check that this is 0.0?
Contributor
Author
There was a problem hiding this comment.
when i tried to check i got a value from the first failed test instance.
arminsabouri
approved these changes
Mar 2, 2026
Collaborator
arminsabouri
left a comment
arminsabouri
left a comment
There was a problem hiding this comment.
Ack.
Please squash your commits in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests in the codebase had missing or inadequate assertions:
println!for debugging instead of actual validationTODOcomments indicating incomplete verification