Open
Conversation
We validate that the dpd path lives at the expected location on start. However, this check can throw a false positive if we point to the exe via a symlink. This patch canonicalizes the exe path before validating so that we validate the real exe path, which may differ from env::current_exe().
4459c74 to
8c394af
Compare
Author
|
For context, I'm trying to run simulated omicron on my macbook, and getting a validation error from the dpd stub: Because the dpd stub on my PATH is a symlink: If I change my PATH to point to the symlinked directory directly, it works, but it occurred to me that this would be simpler if dpd checked its canonical path for validation instead. @david-crespo pointed out that this seems to be a macos-specific issue, since we aren't aware of the same problem on linux. I think canonicalizing the exe path is probably reasonable either way, but I'm wondering why this hasn't come up on linux so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We validate that the dpd path lives at the expected location on start. However, this check can throw a false positive if we point to the exe via a symlink. This patch canonicalizes the exe path before validating so that we validate the real exe path, which may differ from env::current_exe().
Submitted to avoid a PATH workaround for running simulated omicron on macos. h/t @david-crespo.