Fix missing $joinMap in AbstractQueryConverter#968
Open
sad270 wants to merge 1 commit intooroinc:masterfrom
Open
Fix missing $joinMap in AbstractQueryConverter#968sad270 wants to merge 1 commit intooroinc:masterfrom
sad270 wants to merge 1 commit intooroinc:masterfrom
Conversation
in AbstractQueryConverter::getParentJoinIdForVirtualColumnJoin method, `$joinMap` variable i missing.
|
Thank you for your pull request. It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/ If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits. Once you've signed the CLA, please allow for some time for the submission to be processed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
AbstractQueryConverter::getParentJoinIdForVirtualColumnJoinmethod,$joinMapvariable is missing.So we never enter in last elseif
isset($joinMap[$parentAlias]['processed'])And when we have 2 joins in a virtual_fields the second join is not added in DQL
Example:
Need for fix this oroinc/crm#346