React fragment shorthand syntax support#300
Open
LumaLivy wants to merge 2 commits intoorktes:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #258 by adding in support for fragment shorthand syntax.
I've covered adding in the valid grammar as a separate regex check for tag opening and closing because things got weird when I tried to amend the existing tag open and close regex. Additionally I changed the regex in atom-react.coffee to allow auto-completion of fragments, which seems to have no adverse effects from my testing.
Unrelated to this package, bracket-matcher seems to be unable to properly highlight fragment tags due to them missing a tag name. This was the only side effect I noticed.