Skip to content

Add new properties to immoscout mappings#275

Open
Pr0mises wants to merge 2 commits intoorangecoding:masterfrom
Pr0mises:master
Open

Add new properties to immoscout mappings#275
Pr0mises wants to merge 2 commits intoorangecoding:masterfrom
Pr0mises:master

Conversation

@Pr0mises
Copy link

Added few more properties for buying a house

Added few more properties for buying a house
@Pr0mises Pr0mises changed the title Add new properties to real estate translation mappings Add new properties to immoscout mappings Feb 28, 2026
Copy link
Owner

@orangecoding orangecoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pr0mises Thanks.

Can you add tests for this as well in immoscout-web-translator.test?

@Pr0mises
Copy link
Author

Pr0mises commented Mar 8, 2026

@orangecoding I did not forget about this PR, but I'm not sure how to add proper tests to this as I'm unable to get a proper test docker up.

I had two thoughts, adding the different house URLs inside testdata.json or add explicit tests inside immoscout-web-translator.test
e.g. testdata.json:

"buyVilla": {
    "url": "https://www.immobilienscout24.de/Suche/de/nordrhein-westfalen/duesseldorf/villa-kaufen?numberofrooms=1.0-10000.0&price=1.0-1000000.0&livingspace=1.0-10000.0&enteredFrom=result_list",
    "type": "housebuy"
  },

immoscout-web-translator.test:

it('should recognize villa-kaufen as housebuy', () => {
    const webUrl =
      'https://www.immobilienscout24.de/Suche/de/berlin/berlin/villa-kaufen';

    const converted = convertWebToMobile(webUrl);
    const queryParams = new URL(converted).searchParams;
    
    expect(queryParams.get('realestatetype')).to.equal('housebuy');
  });

the second one should be already be covered by the
it('shouldFindResultsForEveryTestData', async () => { function using the testdata.json, shouldn't it?

Also for the new PARAM_NAME_MAP those should be already covered shouldn't them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants