miniupnpd: add config support for ext_allow_private_ipv4#28644
Open
commondservice wants to merge 1 commit intoopenwrt:masterfrom
Open
miniupnpd: add config support for ext_allow_private_ipv4#28644commondservice wants to merge 1 commit intoopenwrt:masterfrom
commondservice wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Currently miniupnpd defaults to disable forwarding if it detects wan ipv4 is private address. A miniupnpd config called `ext_allow_private_ipv4` exists which enables forwarding in the above case. Add parsing to init script so that uci config can enable this option. Signed-off-by: James Liu <commondservice@outlook.com> Signed-off-by: commondservice <134219876+commondservice@users.noreply.github.com>
Contributor
|
Note: The following longer-existing UCI option can be set in /etc/config/upnpd as a workaround with the current package to force enable IPv4 mapping in this case: |
Contributor
|
I'll try to bring my PR in next weeks. This will include this option and another CGNAT option (4 UI options). See: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: "common packages maintainers" (according to https://openwrt.org/packages/pkgdata/miniupnpd-nftables)
Description:
Currently miniupnpd defaults to disable forwarding if it detects wan ipv4 is private address. A miniupnpd config called
ext_allow_private_ipv4exists which enables forwarding in the above case. Add parsing to init script so that uci config can enable this option.Sidenotes: This is my 1st commit to openwrt, I read the contribution guide, but there appears to be a two-line signoffs caused by github, which I don't know how to circumvent. Feel free to tell me where's wrong.
Hope it can get into v25.12, but also fine otherwise.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.