Skip to content

collectd: remove redundant liblua link flag#28632

Open
LGA1150 wants to merge 1 commit intoopenwrt:masterfrom
LGA1150:collectd-noliblua
Open

collectd: remove redundant liblua link flag#28632
LGA1150 wants to merge 1 commit intoopenwrt:masterfrom
LGA1150:collectd-noliblua

Conversation

@LGA1150
Copy link
Contributor

@LGA1150 LGA1150 commented Feb 25, 2026

📦 Package Details

Maintainer: @jow- @hnyman

Description:
The link flag makes the main program depend on liblua in official package feeds, even if collectd-mod-lua is not installed. The plugin is already linked against liblua.so, so this can be removed.


🧪 Run Testing Details

  • OpenWrt Version: r33209-ba57225066
  • OpenWrt Target/Subtarget: mediatek/mt7622
  • OpenWrt Device: Xiaomi Redmi Router AX6S

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

The link flag makes the main program depend on liblua in official
package feeds, even if collectd-mod-lua is not installed.
The plugin is already linked against liblua.so, so this can be removed.

Signed-off-by: Qingfang Deng <dqfext@gmail.com>
@hnyman
Copy link
Contributor

hnyman commented Feb 25, 2026

The removed code originates from @feckert / PR #8138
Would be good to hear his opinion.

(I agree that having liblua always linked is not optimal. Lua is largely removed from LuCI already, so its role in OpenWrt has gone down a lot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants