[18.0-fr5] Validate ansibleHost and ctlplane fixedIP for pre-provisioned nodes #1810
Conversation
… nodes For pre-provisioned dataplane nodes, ansibleHost must be a valid IP address. This is required because the controller defaults the ctlplane network fixedIP from ansibleHost during IPAM reservation, ensuring the reserved IP matches the already-configured node interface. Without a valid IP, IPAM could reserve a different address and break connectivity during deployment. The validating webhook enforces that for pre-provisioned nodes: - ansibleHost is not empty - ansibleHost is a valid IP address The controller (ipam.go) defaults the ctlplane fixedIP from ansibleHost when not already set. The ctlplane network is identified using the netServiceNetMap from NetConfig, so it works regardless of the network name. Signed-off-by: rabi <ramishra@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c1710dbc6cad454b9ba00e4a0c536bbc ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 41s |
|
we need to build the ansibleee-runner image for the fr5 branch ... |
|
submitted openstack-k8s-operators/edpm-ansible#1115 so that we could trigger it manually |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
recheck |
openshift-merge-bot
bot
merged commit 7adc4b9
into
openstack-k8s-operators:18.0-fr5
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is an automated cherry-pick of #1802
/assign rabi