-
Notifications
You must be signed in to change notification settings - Fork 147
[reproducer] Extend script argument by adding current-zuul-variables.yml #3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reproducer] Extend script argument by adding current-zuul-variables.yml #3668
Conversation
During the ZIronic deployment, the reproducer-variables.yml is generated, which might not be up-to-date what we want to achieve using Zuul job. It means, that if we want to provide some variables that should be respected by e.g. deploy-architecture.sh script, we need to add it as a last argument, then if the variable is defined earlier, it would not be respected. In that case, we will be doing a dump of Zuul variables to current-zuul-variables.yml file then read it as last variable file. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70e24018806d48159b80e199df421436 ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0008160438 failed in 0s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/90bfe438c1d14553954ac0f21a4fa1b4 ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0008160459 failed in 0s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0bcb33377b6143d09afb49c9249e3685 ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0008160521 failed in 0s |
|
Probably we don't need to create new file, just make a backup of old file and overwrite current vars.
|
During the ZIronic deployment, the reproducer-variables.yml is generated, which might not be up-to-date what we want to achieve using Zuul job. It means, that if we want to provide some variables that should be respected by e.g. deploy-architecture.sh script, we need to add it as a last argument, then if the variable is defined earlier, it would not be respected.
In that case, we will be doing a dump of Zuul variables to current-zuul-variables.yml file then read it as last variable file.