-
Notifications
You must be signed in to change notification settings - Fork 147
Add stackviz integration for tempest test results #3617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stackviz integration for tempest test results #3617
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
This commit adds automatic stackviz HTML report generation for tempest test results in the test_operator role. Changes: - Add generate-stackviz.yml task file to handle stackviz generation - Integrate stackviz generation into run-test-operator-job.yml - Add cifmw_test_operator_generate_stackviz config variable - Add STACKVIZ_INTEGRATION.md documentation The integration automatically: 1. Finds tempest_results.subunit.gz in collected logs 2. Decompresses the subunit file 3. Runs stackviz-export to generate interactive HTML 4. Stores output in <artifacts_basedir>/stackviz/html/ Users can disable this feature by setting: cifmw_test_operator_generate_stackviz: false Signed-off-by: Saurabh Agarwal <sauragar@redhat.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
d4f8034 to
112ec6b
Compare
michburk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be interested in seeing what the stackviz report looks like. Have you run these changes and generated an example report? If you need to include a link to somewhere downstream, please share the link via a comment on a jira ticket. Be sure to mark that comment as Restricted to Red Hat Employee, then share the jira link here.
Additionally, please include [test_operator] at the beginning of the commit title.
Thanks!
| cifmw_test_operator_delete_logs_pod: false | ||
| cifmw_test_operator_privileged: true | ||
| cifmw_test_operator_selinux_level: "s0:c478,c978" | ||
| cifmw_test_operator_generate_stackviz: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blocking] Missing a new entry in roles/test_operator/README.md describing this var
| @@ -0,0 +1,120 @@ | |||
| # Stackviz Integration for Tempest Results | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blocking] Don't put this markdown file in the tasks directory. Additionally, I think a lot of the information in this file is unnecessary/irrelevant. Maybe include a bit about stackviz in roles/test_operator/README.md instead?
| state: directory | ||
| mode: "0755" | ||
|
|
||
| - name: Check if stackviz is installed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[non-blocking] This isn't necessary, you can move the pip + stackviz installation outside of the block and remove this check.
| ======================================== | ||
| Location: {{ stackviz_html_path }} | ||
|
|
||
| To view the report, open the following file in your browser: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blocking] Unless I'm mistaken, this file is primarily going to be accessed via the zuul logs. I think telling people to open it from their browser as if it were on their local machine is confusing and unhelpful.
- Remove unnecessary stackviz installation check (pip is idempotent) - Update success message to reference artifacts path instead of local file URL for Zuul CI context Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7d9db44b9d1a43ecbbe99b6e954fd194 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 11s |
|
Sorry this is another approach which I am using before but now I am going with the Generation of Stackviz report through Python code which I have done in another MR: #3642 |
This commit adds automatic stackviz HTML report generation for tempest test results in the test_operator role.
Changes:
The integration automatically:
Users can disable this feature by setting:
cifmw_test_operator_generate_stackviz: false