NO-JIRA: hack: steps to run router locally#712
NO-JIRA: hack: steps to run router locally#712jcmoraisjr wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jcmoraisjr: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign |
jcmoraisjr
force-pushed
the
hack-local-debug
branch
from
658b34b to
ee6c1a8
Compare
| cp images/router/haproxy/conf/* "${haproxydir}/conf/" | ||
| } | ||
|
|
||
| router_run() { |
There was a problem hiding this comment.
It would be nice to have a check to make sure that the KUBECONFIG is set properly before running?
There was a problem hiding this comment.
I see, I'm not sure, I though about this and ended up choosing the simplicity, since router itself will check this for us - although its message isn't that clear:
make local-run
hack/local-router.sh run
/var/lib/haproxy prepared
github.com/openshift/router/pkg/router/template
github.com/openshift/router/pkg/router/metrics
github.com/openshift/router/pkg/cmd/infra/router
I0210 11:56:03.528934 399293 template.go:561] "msg"="starting router" "logger"="router" "version"="majorFromGit: \nminorFromGit: \ncommitFromGit: \nversionFromGit: unknown\ngitTreeState: \nbuildDate: \n"
error: Unable to configure Kubernetes client: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
exit status 1
make: *** [Makefile:46: local-run] Error 1
What do you think from the user's perspective? I'm fine for both, either checking or letting router check for me.
There was a problem hiding this comment.
Ah okay then if router checks then fine
hack/local-router.sh
Outdated
| sudo chown "${USER}:${USER}" "$haproxydir" | ||
| fi | ||
| rm -rf "${haproxydir}/{conf,run}" | ||
| mkdir "${haproxydir}/{conf,run}" |
There was a problem hiding this comment.
IIUC the brace expansion won't work inside the double quotes right?
There was a problem hiding this comment.
It will, all var expansions work under double quotes, they are considered literal under single quote instead. Quoting is important in order to protect against white spaces in the path.
Otoh there are some shells that don't support this sort of expansion, ash from Alpine is an example if I'm not mistaken. Since the script uses shebang, it enforces bash despite of the shell the user is using.
Adding some doc on how to run OpenShift router locally, which improves the "code + run + test + debug" experience.
jcmoraisjr
force-pushed
the
hack-local-debug
branch
from
ee6c1a8 to
ed8c9a5
Compare
|
/retest |
|
@jcmoraisjr: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thanks @jcmoraisjr |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thealisyed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -1 +1,2 @@ | |||
| /.vscode | |||
There was a problem hiding this comment.
Hmm was going to say if we should follow how CDO does it's gitignore but seems excessive for this repo
There was a problem hiding this comment.
I see. Wondering if there is a pattern that repos are invited to follow, otherwise we can evolve it whenever we see it being demanded.
There was a problem hiding this comment.
Seems they used this # Created by https://www.gitignore.io/api/go,vim,emacs,visualstudiocode. Interestingly enough the bulk of the gitignore was committed as part of the inital commit and hasn't been touched since (8 years) xD
So seems to be a basic template used (maybe a follow up PR for this repo?)
3 participants
Adding some doc on how to run OpenShift router locally, which improves the "code + run + test + debug" experience.