Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chamalabey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughReplaced the container image reference in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deploy/operator.yaml`:
- Around line 41-43: The CSV template still points to the old image registry;
update the image reference in config/templates/csv-template.yaml (the image:
field under the container spec in the CSV template, e.g., the CSV
.spec.template.spec.containers[*].image entry) to match the new registry string
quay.io/redhat-user-workloads/managed-upgrade-operator-tenant/openshift/managed-upgrade-operator:GENERATED
so it stays consistent with deploy/operator.yaml and the
/hack/generate-operator-bundle.py replacement behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 57ab130f-f5bf-4f7a-becd-e5796b43c110
📒 Files selected for processing (1)
deploy/operator.yaml
deploy/operator.yaml
Outdated
| # Replace this with the built image name | ||
| # This will get replaced on deploy by /hack/generate-operator-bundle.py | ||
| image: quay.io/app-sre/managed-upgrade-operator:GENERATED | ||
| image: quay.io/redhat-user-workloads/managed-upgrade-operator-tenant/openshift/managed-upgrade-operator:GENERATED |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for remaining references to the old image registry path
echo "=== Files still referencing old registry path ==="
rg -n "quay\.io/app-sre/managed-upgrade-operator" --type yaml
echo ""
echo "=== Files referencing new registry path ==="
rg -n "quay\.io/redhat-user-workloads/managed-upgrade-operator-tenant" --type yamlRepository: openshift/managed-upgrade-operator
Length of output: 429
Update csv-template.yaml to use the new image registry path.
The image path in deploy/operator.yaml line 43 has been updated to the new registry (quay.io/redhat-user-workloads/managed-upgrade-operator-tenant/openshift/managed-upgrade-operator:GENERATED), but config/templates/csv-template.yaml line 10 still references the old registry path. Update it to maintain consistency:
Fix for config/templates/csv-template.yaml
- containerImage: quay.io/app-sre/managed-upgrade-operator:GENERATED
+ containerImage: quay.io/redhat-user-workloads/managed-upgrade-operator-tenant/openshift/managed-upgrade-operator:GENERATED🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@deploy/operator.yaml` around lines 41 - 43, The CSV template still points to
the old image registry; update the image reference in
config/templates/csv-template.yaml (the image: field under the container spec in
the CSV template, e.g., the CSV .spec.template.spec.containers[*].image entry)
to match the new registry string
quay.io/redhat-user-workloads/managed-upgrade-operator-tenant/openshift/managed-upgrade-operator:GENERATED
so it stays consistent with deploy/operator.yaml and the
/hack/generate-operator-bundle.py replacement behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
=======================================
Coverage 53.59% 53.59%
=======================================
Files 123 123
Lines 6165 6165
=======================================
Hits 3304 3304
Misses 2668 2668
Partials 193 193 🚀 New features to boost your workflow:
|
|
@chamalabey: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What type of PR is this?
refactor
What this PR does / why we need it?
Updating image repo to images build by konflux pipeline
Which Jira/Github issue(s) this PR fixes?
Fixes #SREP-3765
Special notes for your reviewer:
Pre-checks (if applicable):
Summary by CodeRabbit