[WIP] CONSOLE-4447: Migrate knative-plugin modals to PatternFly 6#16065
[WIP] CONSOLE-4447: Migrate knative-plugin modals to PatternFly 6#16065rhamilto wants to merge 4 commits intoopenshift:mainfrom
Conversation
Update Cancel button variants from "secondary" to "link" in modern PatternFly modals to follow PatternFly standards. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… wrapper - Migrate useCopyCodeModal, FavoriteButton, and TourStepComponent from deprecated Modal wrapper to modern PatternFly Modal components - Remove deprecated Modal wrapper (packages/console-shared/src/components/modal/) - Migrate CatalogDetailsModal and operator-hub-items from deprecated PatternFly Modal to modern Modal components - Preserve ocs-modal CSS class for catalog modal positioning - Fix FavoriteButton form submission bug by adding preventDefault - Fix Guided Tour accessibility warning by closing Help dropdown and blurring focus before starting tour Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Migrate DeleteModal from deprecated factory/modal components to modern PatternFly v6 Modal components - Create reusable ModalFooterWithAlerts component for alert display - Update configure-count-modal and configure-machine-autoscaler-modal to use modern Modal components and ModalFooterWithAlerts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Migrate 7 modals from deprecated @console/internal/components/factory ModalWrapper to modern @patternfly/react-core Modal components: - SinkSourceModal - PubSubModal - SinkPubsubModal - DeleteRevisionModal - SinkUriModal - TestFunctionModal - TrafficSplittingModal Changes: - Replace ModalWrapper with PatternFly 6 Modal in controller components - Replace ModalTitle with ModalHeader (with labelId and data-test-id="modal-title") - Move Form inside ModalBody for consistency - Replace ModalSubmitFooter with ModalFooter or ModalFooterWithAlerts - Add form attribute to submit buttons to connect to form id - Add data-test-id="modal-cancel-action" to cancel buttons for integration tests - Update unit tests to mock PatternFly 6 components - Fix TestFunction bug: service.data.metadata -> service.metadata All modals now follow consistent pattern: - Modal wrapper in Controller component - ModalHeader with accessibility labelId and test ID - Form inside ModalBody with unique id and className="pf-v6-u-mr-md" - Submit button with type="submit" and form attribute - Cancel button with variant="link" and test ID Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@rhamilto: This pull request references CONSOLE-4447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/knative
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@rhamilto: This pull request references CONSOLE-4447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamilto: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
2 participants
Summary
Migrate knative-plugin modals from deprecated factory components to PatternFly 6 Modal components.
This PR migrates 7 modals:
Note: This PR includes changes from #16015, so it should merge first.
Changes
ModalWrapperwith PatternFly 6Modalin controller componentsModalTitlewithModalHeader(withlabelIdanddata-test-id="modal-title")ForminsideModalBodyfor consistencyModalSubmitFooterwithModalFooterorModalFooterWithAlertsformattribute to submit buttons to connect to form iddata-test-id="modal-cancel-action"to cancel buttons for integration testsservice.data.metadata→service.metadataPattern
All modals now follow consistent pattern:
variant="small"labelIdanddata-test-id="modal-title"className="pf-v6-u-mr-md"type="submit"andformattributevariant="link"anddata-test-id="modal-cancel-action"Test plan
🤖 Generated with Claude Code