Skip to content

NO-JRA: Add lint target to Makefile#1341

Open
JoelSpeed wants to merge 2 commits intoopenshift:mainfrom
JoelSpeed:add-lint-target
Open

NO-JRA: Add lint target to Makefile#1341
JoelSpeed wants to merge 2 commits intoopenshift:mainfrom
JoelSpeed:add-lint-target

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Mar 9, 2026

This re-adds a make lint target to the makefile.

This version leverages a vendored golangci-lint codebase, meaning that the anyone running locally, or CI, will always use a consistent version, which is tracked in the go.mod file and updated periodically by someone running go get -tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest

The drawbacks of this approach are that it adds a bunch of stuff to the go.mod as indirects. You could create a separate tools go module if you don't want this to impact your main module go.mod in this way

Summary by CodeRabbit

  • Chores
    • Added a vendored lint runner and a new lint command to enable automated code linting.
    • Bumped Go language version to 1.25.0.
    • Updated numerous dependencies, including testing, linting, cryptography, and tooling packages to improve security, compatibility, and developer tooling.

@JoelSpeed
Copy link
Contributor Author

/hold for discussion

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b169e5c2-abbe-482c-b4ee-8a0a9be66724

📥 Commits

Reviewing files that changed from the base of the PR and between 198dc47 and bf514d5.

📒 Files selected for processing (1)
  • Makefile
🚧 Files skipped from review as they are similar to previous changes (1)
  • Makefile

Walkthrough

Adds a vendored golangci-lint-based lint target to the Makefile, sets PROJECT_DIR and GOLANGCI_LINT variables, and upgrades module tooling and dependencies including Go 1.25 and numerous direct/indirect version bumps with a replace of github.com/onsi/ginkgo/v2 to an OpenShift fork.

Changes

Cohort / File(s) Summary
Linting Infrastructure
Makefile
Adds PROJECT_DIR and GOLANGCI_LINT variables, introduces .PHONY: lint and a lint target that runs vendored golangci-lint via go run -mod=vendor.
Dependency and Tooling Updates
go.mod
Bumps Go version to 1.25.0, adds a tool directive for github.com/golangci/golangci-lint/v2/..., updates several direct deps (logr, ginkgo/v2, gomega, cobra, x/crypto, x/net), refreshes many indirect dependencies, and replaces github.com/onsi/ginkgo/v2 with an OpenShift fork.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: adding a lint target to the Makefile, which is the primary purpose of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test files were modified in this PR; only Makefile and go.mod were changed.
Test Structure And Quality ✅ Passed The PR modifies only Makefile and go.mod with no changes to test files or Ginkgo test code, making the custom check for test quality not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoelSpeed
Once this PR has been reviewed and has the lgtm label, please assign pratikmahajan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
go.mod (1)

281-281: Replace directive pins ginkgo to an older OpenShift fork.

The replace directive pins ginkgo/v2 to github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12, which is based on a December 2024 commit. This is intentional for OpenShift's CI environment compatibility, but note:

  1. The pseudo-version date (2024-12-05) is over a year old relative to the current date
  2. This may miss upstream ginkgo fixes and features

Consider periodically syncing the fork if upstream ginkgo changes are needed.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 281, The go.mod replace directive pins
github.com/onsi/ginkgo/v2 to an older OpenShift fork
(github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12);
update the replace entry to a newer pseudo-version or remove the replace to use
upstream github.com/onsi/ginkgo/v2 if CI no longer requires the fork, then run
go mod tidy and run the test suite to verify compatibility; if keeping the fork
is required, periodically bump the pseudo-version to a more recent commit from
github.com/openshift/onsi-ginkgo/v2 and document the reason for the pin.
Makefile (1)

57-62: Use go tool golangci-lint to leverage the existing tool directive.

The project already declares tool github.com/golangci/golangci-lint/v2/cmd/golangci-lint in go.mod (Go 1.25 fully supports this). Simplify the Makefile to:

GOLANGCI_LINT = go tool golangci-lint

This approach:

  • Uses Go's native tool directive mechanism already declared in go.mod
  • Eliminates the need for manual vendor path specification
  • Works with Go 1.24+ tool caching and management
  • Cleaner and more maintainable than go run -mod=vendor
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Makefile` around lines 57 - 62, Replace the current GOLANGCI_LINT invocation
that uses "go run -mod=vendor ${PROJECT_DIR}/vendor/..." with Go's tool
mechanism: update the GOLANGCI_LINT variable definition so the Makefile uses "go
tool golangci-lint" (affecting the GOLANGCI_LINT variable and the lint target
that calls ${GOLANGCI_LINT} run) so the project leverages the go.mod tool
directive instead of a vendor path.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@go.mod`:
- Line 281: The go.mod replace directive pins github.com/onsi/ginkgo/v2 to an
older OpenShift fork (github.com/openshift/onsi-ginkgo/v2
v2.6.1-0.20241205171354-8006f302fd12); update the replace entry to a newer
pseudo-version or remove the replace to use upstream github.com/onsi/ginkgo/v2
if CI no longer requires the fork, then run go mod tidy and run the test suite
to verify compatibility; if keeping the fork is required, periodically bump the
pseudo-version to a more recent commit from github.com/openshift/onsi-ginkgo/v2
and document the reason for the pin.

In `@Makefile`:
- Around line 57-62: Replace the current GOLANGCI_LINT invocation that uses "go
run -mod=vendor ${PROJECT_DIR}/vendor/..." with Go's tool mechanism: update the
GOLANGCI_LINT variable definition so the Makefile uses "go tool golangci-lint"
(affecting the GOLANGCI_LINT variable and the lint target that calls
${GOLANGCI_LINT} run) so the project leverages the go.mod tool directive instead
of a vendor path.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 60b42846-6ad0-4a7c-8173-050842dad36a

📥 Commits

Reviewing files that changed from the base of the PR and between c4fb92f and 198dc47.

⛔ Files ignored due to path filters (298)
  • go.sum is excluded by !**/*.sum
  • vendor/4d63.com/gocheckcompilerdirectives/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/4d63.com/gocheckcompilerdirectives/checkcompilerdirectives/checkcompilerdirectives.go is excluded by !**/vendor/**, !vendor/**
  • vendor/4d63.com/gochecknoglobals/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/4d63.com/gochecknoglobals/checknoglobals/check_no_globals.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/constructors.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/decorators.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/enums.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/io.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/chavacava/garif/models.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/polyfloyd/go-errorlint/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/allowed.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/analysis.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/lint.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/options.go is excluded by !**/vendor/**, !vendor/**
  • vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/printf.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/config.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/cache.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/directive.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/internal/pattern/list.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields-cache.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/e/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/e/err.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/e/log.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/fields/dict.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/fields/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/fields/field.go is excluded by !**/vendor/**, !vendor/**
  • vendor/dev.gaijin.team/go/golib/fields/list.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/.golangci.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/.goreleaser.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/Makefile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/options.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/4meepo/tagalign/tagalign.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Abirdcfly/dupword/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Abirdcfly/dupword/.goreleaser.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Abirdcfly/dupword/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Abirdcfly/dupword/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Abirdcfly/dupword/dupword.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Abirdcfly/dupword/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AdminBenni/iota-mixing/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/flags/flags.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AlwxSin/noinlineerr/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AlwxSin/noinlineerr/.golangci.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AlwxSin/noinlineerr/.goreleaser.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AlwxSin/noinlineerr/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AlwxSin/noinlineerr/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/AlwxSin/noinlineerr/noinlineerr.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/errname/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/errname/pkg/analyzer/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/errname/pkg/analyzer/facts.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/nilnil/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/nilnil/pkg/analyzer/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/nilnil/pkg/analyzer/config.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/nilnil/pkg/analyzer/func_type_stack.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/analyzer/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/analyzer/checkers_factory.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/analysisutil/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/analysisutil/encoded.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/analysisutil/file.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/analysisutil/format.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/analysisutil/object.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/analysisutil/pkg.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/blank_import.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/bool_compare.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/call_meta.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/checker.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/checkers_registry.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/compares.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/contains.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/empty.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/encoded_compare.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/equal_values.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/error_is_as.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/error_nil.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/expected_actual.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/float_compare.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/formatter.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/go_require.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_basic_type.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_bool.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_comparison.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_context.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_diagnostic.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_encoded.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_error.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_format.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_http.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_interface.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_len.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_naming.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_nil.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_pkg_func.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_suite.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_testing.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/len.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/negative_positive.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/nil_compare.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/printf/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/printf/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/printf/printf.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/regexp.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/require_error.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/suite_broken_parallel.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/suite_dont_use_pkg.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/suite_extra_assert_call.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/suite_method_signature.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/suite_subtest_run.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/suite_thelper.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/checkers/useless_assert.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/config/config.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/config/flag_value_types.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Antonboom/testifylint/internal/testify/const.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/COPYING is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/decode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/deprecated.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/encode.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/error.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/internal/tz.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/lex.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/meta.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/parse.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/type_fields.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/BurntSushi/toml/type_toml.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/.golangci.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/.travis.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/README.adoc is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/comparison.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/definition.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Djarvur/go-err113/err113.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/.golangci.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/CHANGELOG.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/LICENSE.txt is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/Makefile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/SECURITY.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/collection.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/constraints.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/Masterminds/semver/v3/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/.golangci.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/.unqueryvet.example.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/CONTRIBUTING.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/Dockerfile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/RELEASE.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/Taskfile.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/action.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/config.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/analyzer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/concat.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/filter.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/fixes.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/format.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/n1detector.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/bun.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/ent.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/goqu.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/gorm.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/interface.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/jet.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/pgx.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/reform.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/rel.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlboiler.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlx.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/squirrel.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqli_scanner.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/tx_leak_detector.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/pkg/config/config.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/MirrexOne/unqueryvet/schema.json is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/LICENSE is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/depguard.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/internal/utils/errors.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/internal/utils/variables.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/OpenPeeDeeP/depguard/v2/settings.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/.editorconfig is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/.gitignore is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/.golangci.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/.goreleaser.yml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/AGENTS.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/Bitfile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/COPYING is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/Dockerfile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/Justfile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/biome.json is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/chroma.jpg is excluded by !**/*.jpg, !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/coalesce.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/colour.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/delegate.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/doc.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/emitters.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatter.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/api.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/html/html.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/json.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/svg/font_liberation_mono.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/svg/svg.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/tokens.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/tty_indexed.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/formatters/tty_truecolour.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/iterator.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/caddyfile.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/cl.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/dns.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/emacs.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abap.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abnf.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript_3.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ada.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/agda.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/al.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/alloy.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/angular2.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/antlr.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apacheconf.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apl.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/applescript.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arangodb_aql.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arduino.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/armasm.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/atl.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autohotkey.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autoit.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/awk.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ballerina.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash_session.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/batchfile.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/beef.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bibtex.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bicep.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/blitzbasic.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bnf.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bqn.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/brainfuck.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c#.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c++.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c3.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cap_n_proto.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cassandra_cql.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ceylon.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfengine3.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfstatement.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chaiscript.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chapel.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cheetah.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/clojure.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cmake.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cobol.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coffeescript.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/common_lisp.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coq.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/core.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/crystal.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/css.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/csv.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cue.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cython.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/d.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dart.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dax.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/desktop_entry.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/devicetree.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/diff.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/django_jinja.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dns.xml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/alecthomas/chroma/v2/lexers/embedded/docker.xml is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • Makefile
  • go.mod

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2026

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 198dc47 link true /test lint
ci/prow/e2e-agnostic-operator 198dc47 link true /test e2e-agnostic-operator
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change 198dc47 link true /test e2e-agnostic-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift-conformance 198dc47 link true /test e2e-hypershift-conformance
ci/prow/e2e-agnostic-ovn 198dc47 link true /test e2e-agnostic-ovn
ci/prow/e2e-agnostic-ovn-techpreview-serial 198dc47 link true /test e2e-agnostic-ovn-techpreview-serial
ci/prow/e2e-agnostic-ovn-techpreview-serial-2of3 198dc47 link true /test e2e-agnostic-ovn-techpreview-serial-2of3
ci/prow/verify-deps 198dc47 link true /test verify-deps
ci/prow/e2e-hypershift 198dc47 link true /test e2e-hypershift
ci/prow/e2e-agnostic-ovn-upgrade-into-change 198dc47 link true /test e2e-agnostic-ovn-upgrade-into-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant