Skip to content

Make event types lowercase#66

Open
rh-amarin wants to merge 1 commit intoopenshift-hyperfleet:mainfrom
rh-amarin:lowercase
Open

Make event types lowercase#66
rh-amarin wants to merge 1 commit intoopenshift-hyperfleet:mainfrom
rh-amarin:lowercase

Conversation

@rh-amarin
Copy link
Contributor

@rh-amarin rh-amarin commented Mar 6, 2026

Make CloudEvent type property lowercase

Summary by CodeRabbit

  • Bug Fixes
    • Normalized CloudEvent type formatting to use lowercase resource kinds for consistency.

@openshift-ci openshift-ci bot requested review from vkareh and yasun1 March 6, 2026 17:45
@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xueli181114 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 96050bac-d973-4a7f-b407-ff2e9c4017c9

📥 Commits

Reviewing files that changed from the base of the PR and between 8901b4e and 02e3467.

📒 Files selected for processing (2)
  • internal/sentinel/sentinel.go
  • internal/sentinel/sentinel_test.go

Walkthrough

This change normalizes CloudEvent type string construction by ensuring the resource kind is lowercased before inclusion. The modification adds a strings.ToLower() call to the event type building logic in sentinel.go, and the corresponding test expectation is updated to reflect the lowercase format in the emitted CloudEvent type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Make event types lowercase' directly and clearly summarizes the main change: converting CloudEvent type values to lowercase.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant