Skip to content

Conversation

@matthewfeickert
Copy link
Contributor

Description

setuptools is not used at runtime and should not be required as a runtime dependency. It is a build time dependency only to provide a build-backend.

Relevant for conda-forge/openmc-feedstock#85.

https://github.com/openmc-dev/openmc/blob/develop/CONTRIBUTING.md didn't explicitly say that all PRs need to have a motivating issue first, but if that is expected I can open an Issue.

Checklist

  • I have performed a self-review of my own code
  • [N/A] I have run clang-format (version 15) on any C++ source files (if applicable)
  • [N/A] I have followed the style guidelines for Python source files (if applicable)
  • [N/A] I have made corresponding changes to the documentation (if applicable)
  • [N/A] I have added tests that prove my fix is effective or that my feature works (if applicable)

* setuptools is not used at runtime and should not be required as a runtime
  dependency. It is a build time dependency only to provide a build-backend.
@matthewfeickert matthewfeickert marked this pull request as ready for review February 11, 2026 06:34
@matthewfeickert
Copy link
Contributor Author

@paulromano @shimwell @MicahGale As you were the maintainers to touch pyproject.toml in 2025 I'm tagging you for review. Let me know if you have any questions.

@shimwell
Copy link
Member

shimwell commented Feb 11, 2026

Many thanks, and also thanks for your efforts on the conda forge package

let us leave this for a day in case anyone has comments.

We can merge tomorrow if there are no objections

@shimwell shimwell added the Merging Soon PR will be merged in < 24 hrs if no further comments are made. label Feb 11, 2026
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @matthewfeickert! We used to use pkg_resources a while back but have since switched to the standard-library importlib so removing setuptools as a runtime dependency is indeed safe.

@paulromano paulromano merged commit 44da702 into openmc-dev:develop Feb 11, 2026
17 checks passed
@matthewfeickert matthewfeickert deleted the fix/remove-setuptools branch February 11, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merging Soon PR will be merged in < 24 hrs if no further comments are made.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants