-
Notifications
You must be signed in to change notification settings - Fork 605
Approximate multigroup velocity #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
paulromano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonag would love to get your thoughts on this one!
|
Why not tally a 1/v based on the group midpoint energy (I assume logarithmic midpoint is best) if no specific data is present? This could be done void or not. |
|
Do you mean instead of defaulting to speed 0 when 1/v data is missing using velocity that match the logarithmic energy midpoint of the group? |
|
Yep!
…On Fri, Feb 6, 2026, 3:10 PM GuySten ***@***.***> wrote:
*GuySten* left a comment (openmc-dev/openmc#3766)
<#3766 (comment)>
Do you mean instead of defaulting to speed 0 when 1/v data is missing
using velocity that match the logarithmic energy midpoint of the group?
—
Reply to this email directly, view it on GitHub
<#3766 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5GM276B2D4K5FJGJCUMT4KT7NLAVCNFSM6AAAAACT4QSIHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNRSGU4DENBQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Removed validation for group edges in the MGXS class.
|
@nelsonag, can you look at this PR again? |
Description
Currently, void regions in multigroup mode makes openmc crash (#3723).
This PR implements the following changes:
Checklist
I have made corresponding changes to the documentation (if applicable)