fix: remove conflicting <|reserved_200018|>; add token-id uniqueness …#458
Open
jinzhuer wants to merge 1 commit intoopenai:mainfrom
Open
fix: remove conflicting <|reserved_200018|>; add token-id uniqueness …#458jinzhuer wants to merge 1 commit intoopenai:mainfrom
jinzhuer wants to merge 1 commit intoopenai:mainfrom
Conversation
jinzhuer
force-pushed
the
fix/special-ids-unique
branch
from
b38b4ee to
a825d1a
Compare
Author
|
@hauntsaninja could you approve running workflows on this fork PR so CI can start? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
<|reserved_200018|>(duplicate of<|endofprompt|>id=200018).reserved_*specials.tests/test_token_ids_unique.pyto ensure token-id uniqueness.Why
Special token ids must be unique. The duplicate breaks the one-id-per-token invariant.
Related Issue
Fixes #457
Tests
The new test fails before this change and passes after.
All existing tests pass.
Compatibility
No functional change; only removes the redundant
<|reserved_200018|>entry.