add permit to escrow contracts #1007
Draft
+490
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ERC20Permit Support to Escrow Contracts
Summary
This PR adds ERC20Permit (EIP-2612) support to both
EscrowandEnterpriseEscrowcontracts, allowing users to deposit tokens without requiring a separate approval transaction. This improves user experience by reducing gas costs and transaction complexity.Motivation
Currently, users must perform two transactions to deposit tokens into escrow:
With ERC20Permit support, users can combine these into a single transaction by providing a permit signature, eliminating the need for a separate approval transaction. This reduces gas costs and improves the user experience, especially for users interacting with the escrow contracts frequently.
How It Works
depositWithPermitwith the signature parameterspermiton the token to approve itself_depositfunction to complete the depositDepositevent is emitted as regular depositsSecurity Features
nonReentrantmodifier_depositfunction as regular deposits