Conversation
1. salivary gland ducto-acinar unit 2. parotid gland ducto-acinar unit 3. sublingual gland ducto-acinar unit 4. submandibular gland ducto-acinar unit 5. dentogingival junction close #3657
nicolevasilevsky
requested review from
RiveraAndrea83
and removed request for
cmungall
|
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -base file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsdentogingival junction
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsdentogingival junction
|
src/ontology/uberon-edit.obo
Outdated
| [Term] | ||
| id: UBERON:8000010 | ||
| name: salivary gland ducto-acinar unit | ||
| def: "A lobule of a salivary gland consisting of secretory acini together with their contiguous ductal segments, including the intercalated duct and striated duct, together with associated myoepithelial cells, stromal tissue, and vasculature. This structural-functional unit is responsible for the production of primary saliva by the acinar cells and its ionic modification during transit through the ductal segments." [PMID:24862590, PMID:30855909] |
There was a problem hiding this comment.
I believe that the lobule contains the ducto-acinar unit. Consider reflecting this in the defintion
There was a problem hiding this comment.
I revised the def
src/ontology/uberon-edit.obo
Outdated
| comment: Also known as the "salivon" in classical salivary physiology literature. The three major salivary glands (parotid, submandibular, sublingual) contain gland-specific variants of this unit that differ in acinar cell composition (serous vs. mucous vs. mixed). | ||
| synonym: "salivary gland ducto-acinar" RELATED [] | ||
| synonym: "salivon" EXACT [] | ||
| is_a: UBERON:0009911 ! lobule |
There was a problem hiding this comment.
i think here part_of is probably better
There was a problem hiding this comment.
this makes sense, I revised this and made this a subclass of 'organ subunit'
src/ontology/uberon-edit.obo
Outdated
| [Term] | ||
| id: UBERON:8000013 | ||
| name: submandibular gland ducto-acinar unit | ||
| def: "A salivary gland ducto-acinar unit that is part of the submandibular gland, consisting of a mixture of predominantly serous acini (approximately 90%) with a minority of mucous acini, together with their contiguous ductal segments, and associated myoepithelial cells, stromal tissue, and vasculature. This unit produces a mixed serous-mucous saliva." [PMID:24862590, PMID:30855909] |
There was a problem hiding this comment.
if the 90% statement is stable across species can be kept otherwise i would suggest to generalise it (i.e. predominantly).
There was a problem hiding this comment.
updated def to remove approx 90%
src/ontology/uberon-edit.obo
Outdated
| synonym: "dentogingival complex" RELATED [] | ||
| synonym: "gingival attachment" RELATED [] | ||
| synonym: "supracrestal tissue attachment" RELATED [] | ||
| is_a: UBERON:0001828 ! gingiva |
There was a problem hiding this comment.
i'd consider using only part_of as it represents the space between gingival tissue and tooth surface.
There was a problem hiding this comment.
I revised this and added the superclass 'anatomical junction'
|
Thanks @RiveraAndrea83, I addressed all of your comments. |
|
Note to self / To do:
|
2 participants
close #3657
cc @zhengj2007 @cmungall