fix: Windows CRLF compatibility for core functions#31
Merged
maxim-uvarov merged 2 commits intomainfrom Dec 30, 2025
Merged
Conversation
Apply CRLF→LF normalization at input and explicit LF output for: - set-x: normalize input, use str join "\n" - extract-command-code: use str join "\n" - embeds-update: normalize input - embeds-remove: normalize input, use str join "\n" - execute-and-parse-results: replace to text in generated code - variable-definitions-to-record: normalize input, handle errors gracefully - capture-marker: export the function (was def, now export def) Following numd's Windows compatibility pattern. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2 tasks
Cleaner approach: change the closure source to use `str join "\n"` directly rather than patching `to text` via string replacement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows compatibility fixes following numd's pattern:
CRLF→LF normalization at input:
set-xembeds-updateembeds-removevariable-definitions-to-recordExplicit LF output (
str join "\n"instead ofto text):set-xextract-command-codeembeds-removeexecute-and-parse-resultsBug fix:
capture-marker: Changed fromdeftoexport def(was not exported, causing silent import failures on Windows)Error handling:
variable-definitions-to-record: Handle empty parse results and subprocess errors gracefullyTest plan
🤖 Generated with Claude Code