Skip to content

Comments

src: fix copy-paste bug using wrong argument index for flags in JSUDPWrap#61948

Open
cuiweixie wants to merge 1 commit intonodejs:mainfrom
cuiweixie:bugfix
Open

src: fix copy-paste bug using wrong argument index for flags in JSUDPWrap#61948
cuiweixie wants to merge 1 commit intonodejs:mainfrom
cuiweixie:bugfix

Conversation

@cuiweixie
Copy link

…Wrap

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 23, 2026
@cuiweixie cuiweixie changed the title src: fix copy-paste bug using wrong argument index for flags in JSUDP… src: fix copy-paste bug using wrong argument index for flags in JSUDPWrap Feb 23, 2026
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Do you happen to have a regression test that you could add for this?

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Feb 23, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2026
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.77%. Comparing base (da5efc4) to head (c22c34a).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/js_udp_wrap.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61948      +/-   ##
==========================================
+ Coverage   88.84%   89.77%   +0.93%     
==========================================
  Files         674      674              
  Lines      204957   205605     +648     
  Branches    39309    39419     +110     
==========================================
+ Hits       182087   184575    +2488     
+ Misses      15088    13267    -1821     
+ Partials     7782     7763      -19     
Files with missing lines Coverage Δ
src/js_udp_wrap.cc 0.80% <0.00%> (ø)

... and 184 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
@cuiweixie
Copy link
Author

😬

Do you happen to have a regression test that you could add for this?

No, i do not have a test.But it is,obviously a right fix, i think.

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2026
@cuiweixie
Copy link
Author

@addaleax Can you help with the ci failed, It seems is unrelated to this pr.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants