test: fix case-insensitive path matching on Windows#61682
Open
mcollina wants to merge 1 commit intonodejs:mainfrom
Open
test: fix case-insensitive path matching on Windows#61682mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina wants to merge 1 commit intonodejs:mainfrom
Conversation
On Windows, file paths are case-insensitive but string comparison is case-sensitive. When the drive letter case differs between the computed project root and the actual output (e.g., 'C:/' vs 'c:/'), the path replacement in transformProjectRoot() would fail. This fix uses case-insensitive regex replacement on Windows to ensure paths are correctly normalized in snapshot tests regardless of drive letter casing. Refs: nodejs/reliability#1453
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61682 +/- ##
==========================================
+ Coverage 89.75% 89.76% +0.01%
==========================================
Files 674 674
Lines 204394 204394
Branches 39278 39274 -4
==========================================
+ Hits 183448 183482 +34
+ Misses 13238 13232 -6
+ Partials 7708 7680 -28 🚀 New features to boost your workflow:
|
legendecas
approved these changes
Feb 4, 2026
github-actions
bot
removed
the
request-ci
Collaborator
StefanStojanovic
approved these changes
Feb 5, 2026
Collaborator
Collaborator
watilde
approved these changes
Feb 5, 2026
Collaborator
legendecas
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky
test-node-output-sourcemapstest on Windows CI.Problem
On Windows, file paths are case-insensitive but JavaScript string comparison is case-sensitive. When the drive letter case differs between the computed project root (e.g.,
C:/workspace/...) and the actual output from child processes (e.g.,c:/workspace/...), the path replacement intransformProjectRoot()would fail.This causes snapshot tests to fail with errors like:
Solution
Use case-insensitive regex replacement (
giflag) on Windows to ensure paths are correctly normalized regardless of drive letter casing.Verification
Tested locally with
python3 tools/test.py --repeat 20 test/parallel/test-node-output-sourcemaps.mjs- all passed.Refs: nodejs/reliability#1453