chore: adjust tsconfig.json settings#532
Merged
aduh95 merged 1 commit intonodejs:mainfrom Jul 17, 2024
wojtekmaj:proper-tsconfig
Merged
chore: adjust tsconfig.json settings#532aduh95 merged 1 commit intonodejs:mainfrom wojtekmaj:proper-tsconfig
aduh95 merged 1 commit intonodejs:mainfrom
wojtekmaj:proper-tsconfig
Conversation
Because Corepack is bundled with esbuild, the correct, recommended tsconfig.json settings are: - module: preserve - moduleResolution: bundler This ensures that modules are resolved the way esbuild resolves them, and opens us to using e.g. package.json exports (which will come in handy in the next PR in which I update tar dependency).
merceyz
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we use Vitest (#349), tests won't go crazy because of this change.
Because Corepack is bundled with esbuild, the correct, recommended tsconfig.json settings are:
This ensures that modules are resolved the way esbuild resolves them, and enables us to use e.g. package.json
exports(which will come in #533).