fix: [Phase 3] Implement Intrinsic Bond Order (IBO)#6
Open
newtontech wants to merge 1 commit intomainfrom
Open
fix: [Phase 3] Implement Intrinsic Bond Order (IBO)#6newtontech wants to merge 1 commit intomainfrom
newtontech wants to merge 1 commit intomainfrom
Conversation
Fixes #3 This commit implements intrinsic bond order (IBO) calculation with bond polarity correction as specified in Issue #3. Key features: - Calculate intrinsic bond strength using Wiberg bond orders - Implement bond polarity correction based on electronegativity differences - Generate bond order matrix for all atom pairs - Compare with Wiberg bond orders for analysis Implementation details: - Created pymultiwfn/bonding/intrinsic.py with core IBO algorithms - Added get_intrinsic_bond_order() and get_intrinsic_bond_order_matrix() methods to the Bonding class - Implemented electronegativity-based polarity correction - Added comprehensive test suite with 19 tests The IBO is calculated as: IBO_ij = W_ij * (1 - polarity_correction) where polarity_correction accounts for ionic character based on electronegativity differences and charge transfer.
|
🤖 Hi @newtontech, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @newtontech, but I was unable to process your request. Please see the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements intrinsic bond order (IBO) calculation with bond polarity correction as specified in Issue #3. The IBO provides a measure of the intrinsic covalent character of chemical bonds by accounting for ionic character through electronegativity-based polarity corrections.
Changes
New file:
pymultiwfn/bonding/intrinsic.py- Core IBO implementationIntrinsicBondResultdataclass for structured resultsUpdated file:
pymultiwfn/bonding/bonding.py- Bonding class integrationget_intrinsic_bond_order()method for single bond pairget_intrinsic_bond_order_matrix()method for all bondsNew file:
tests/bonding/test_intrinsic_bond.py- Comprehensive test suiteImplementation Details
The intrinsic bond order is calculated using the formula:
where:
W_ijis the Wiberg bond orderpolarity_correctionaccounts for ionic character based on:Key Features:
Testing
All tests pass successfully:
Manual testing with mock data confirms:
API Usage
Fixes
Fixes #3