refactor: Improve performance of source control methods #25298
+137
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alielkhateeb
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add findByIds tests
alielkhateeb
force-pushed
the
LIGO-128-improve-performance-of-source-control-methods
branch
from
145db7b to
2da3d34
Compare
alielkhateeb
commented
Feb 4, 2026
| outOfScopeWF = outOfScopeWF.filter( | ||
| (wf) => !wfLocalVersionIds.some((local) => local.id === wf.id), | ||
| ); | ||
| outOfScopeWF = outOfScopeWF.filter((wf) => !wfLocalIds.has(wf.id)); |
Author
There was a problem hiding this comment.
The idea here is that Set#has() is O(1) compared to some which is O(n)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR should only be an improvement to the performance of pull/push, as well as some readability improvements.
Related Linear tickets, Github issues, and Community forum posts
Ligo-128
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)