Added proper themes for GTK apps#1149
Added proper themes for GTK apps#1149SakibShahariar wants to merge 17 commits intomylinuxforwork:mainfrom
Conversation
|
Thank you vety much. I like what I see in your screenshot. But, Does This require so many files? Is there a way to only change the colors without adding all the icons? |
|
Yeah, there are many svg icons. Basically, I downloaded gruvbox gtk theme and edited the css files to match matugen. So, I didn't pay that much attention to the assets folder. I guess it should work without those but you should check yourself or I can check tomorrow and confirm if they needed or not. |
|
I checked and they can be removed by editing the css files. But svg icons are really small and don't take much space(less than 1 mb total) . But if you want I can edit them. |
If you have time, it would be great. |
|
ok I will edit them. Btw, check if they work for different apps like normal gtk3 and gtk4, flatpak apps and root accessed apps like gparted |
Great. |
|
Done |
|
Thank you. I can’t merge it into 2.9.9.2 anymore but will test it directly after the release. |
|
Ok. |
|
When is the release, it's bothering me hahaha |
|
Is this PR still going through? |
|
I guess he forgot |
|
Thanks for the reminder. But that means that the Gnome-Materials Theme needs to be installed first, right? This must be handled by the setup.sh script that will be executed through the Dotfiles Installer. Or do you have another idea? |
|
I’m not sure what the best way is, as I haven’t worked with installers before. So, we need to put my Material-Gnome theme in the ~/.themes folder. Then, we have to make it the default GTK theme for both Flatpak and regular apps. To make the theme change live (without restarting), I use gsettings in GNOME to change the color scheme. I’m not currently using Hyprland, so I can’t say if it will work there or not. |
Description
This makes the gtk apps more vibrant with proper css for both gtk3 and gtk4 and probably flatpak too.
Changes
Context
Regular theme doesn't look that good, that's why I want to add this.
How Has This Been Tested?
Checklist
Please ensure your pull request meets the following requirements:
Screenshots
Additional Notes
Check if gtk4 apps are looking right. Also check gtk3 apps, and flatpak apps. If doesn't work, we need to set theme using gsettings and for flatpak need to set up it's theme.