Conversation
mwclemy
requested review from
Jameson13B,
ash-wright123,
codingLogan,
emilysallstrom and
wesrisenmay-mx
as code owners
|
super close! just need to bold "MX Bank" in the body. |
| const institution = useSelector(getSelectedInstitution) | ||
| const initialConfig = useSelector(selectInitialConfig) | ||
| const containerRef = useRef(null) | ||
| const styles = getStyles() |
There was a problem hiding this comment.
We have an ADR to use css modules. Let's use css modules.
There was a problem hiding this comment.
I initially started with css modules, but since the styles I have are theme overrides that need to be applied via the sx prop and sx expects a style object rather than class names, there isn’t a way to inject css module classes. Given that constraint, I had to use inline styles in this case.
| import * as connectActions from 'src/redux/actions/Connect' | ||
|
|
||
| // Mock useDispatch | ||
| vitest.mock('react-redux', async () => { |
There was a problem hiding this comment.
These tests feel very mocky, so they don't give me much confidence that things will work when they're actually put together. How can you mock as little as possible while ensuring the functionality is tested?
There was a problem hiding this comment.
Unless you have better ideas, I couldn’t think of another way to test the action dispatch without mocking useDispatch.
Updated with a new screenshot in the description. |
|
looks good! |
3 participants
Issue: https://mxcom.atlassian.net/browse/CT-1922
This PR introduces a new screen to guard demo users from connecting to real institutions.
Screenshot
Testing instructions
demo_user/password123!as the username and password for sand)