Expand omni search to include notes and todos#912
Merged
multiplex55 merged 1 commit intomasterfrom Feb 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
o/o list) pipeline so users see folders, bookmarks, apps, notes and todos in one combined search.Description
note: NotePluginandtodo: TodoPluginfields toOmniSearchPluginand initialized them inOmniSearchPlugin::new(...)alongsidefoldersandbookmarks.search_allto call per-source collectors:collect_folder_results,collect_bookmark_results,collect_app_results,collect_note_results, andcollect_todo_resultsso each source uses its native query form (empty rest →note list/todo list, non-empty rest →note {rest}/todo {rest}).collect_app_resultsand preserved the existing FST subsequence search plus the linear fallback when index building fails.dedup_actionsto remove duplicates by a stable key composed of theactionstring and a normalized, lowercased label while preserving first-seen ordering, and updateddescription()to reflect the expanded scope.Testing
cargo fmt --all, which completed successfully.cargo checkandcargo check --lib, both of which were blocked by an environment/system dependency error fromalsa-sys(missingalsa.pc/ pkg-config), so a full build and automated test run could not be completed in this environment.Codex Task