Preserve plugin-resolved results in exact match mode#910
Merged
multiplex55 merged 2 commits intomasterfrom Feb 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
note:new:*,note:open:*) when a plugin had already resolved a command likenote todayornote search <term>.query:*actions) while avoiding re-filtering of plugin-side search/transform outputs.Description
fn should_bypass_exact_post_filter(query: &str, action: &str) -> boolto detect explicit plugin commands and non-query:actions that should bypass exact-mode display-text post-filtering.search_pluginsin both exact-mode branches, including thegweb-search branch and the generalplugin_resultsbranch that usesquery_term_lc.query:*actions participating in the normal exact display filtering.note today,note search <term>) must not be re-filtered by the launcher's label/description exact matching, and add a small test plugin plusexact_mode_keeps_plugin_resolved_results_but_filters_query_suggestionsto validate behavior.Testing
cargo fmt --checkwhich succeeded.cargo test exact_mode_keeps_plugin_resolved_results_but_filters_query_suggestions -- src/gui/mod.rsbut the build failed in this environment due to a missing system dependency (alsa/alsa.pc) required by thealsa-syscrate invoked during the test build, so the new test could not complete here.alsadevelopment files).Codex Task