Persist note details visibility preference#904
Merged
multiplex55 merged 2 commits intomasterfrom Feb 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
note_show_details: booltoSettingswith#[serde(default = "default_note_show_details")]and wireddefault_note_show_details()intoimpl Default for Settingsso the missing field defaults tofalse(details hidden). (file:src/settings.rs)SettingsEditorwith anote_show_detailsfield, hydrated it infrom_settings(...), included it into_settings(...), and added a checkbox labeled"Show note details by default"under the existing "Note settings" section. (file:src/settings_editor.rs)note_show_detailstoLauncherApp, threading it throughupdate_paths(...), initializing it from loaded settings, and using it when creating note panels viaNotePanel::from_note_with_details(note, self.note_show_details). (file:src/gui/mod.rs)from_note_with_details(...)constructor and aset_show_metadata(...)helper onNotePaneland added write-through persistence on toggles so clicking Hide/Show Details updatesSettings.note_show_detailson disk only when the state actually changes and surfaces load/save errors viaapp.set_error(...). (file:src/gui/note_panel.rs)note_show_detailsand note-panel tests for constructor behavior, toggle persistence (writes only on change), and existing metadata visibility gating. (files:src/settings.rs,src/gui/note_panel.rs)src/plugin_editor.rs)Testing
cargo fmt -- --check, which succeeded.note_show_detailsand note panel behavior, butcargo testin this environment failed due to an external system dependency (thealsasystem library /pkg-configis missing which triggersalsa-sysbuild failures), so the new tests could not be executed end-to-end here.Codex Task