Refactor theme settings dialog into a two-column editor#899
Merged
multiplex55 merged 1 commit intomasterfrom Feb 20, 2026
Merged
Refactor theme settings dialog into a two-column editor#899multiplex55 merged 1 commit intomasterfrom
multiplex55 merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
980.0and reorganized the content into a two-column layout usingui.columns(2, ...)insrc/gui/theme_settings_dialog.rs.section_base_mode,section_core_surfaces, andsection_text_and_linksin the left column, andsection_widgets,section_selection,section_semanticpluspreviewin the right column.reset_core_surfaces_to_mode_defaults,reset_text_and_links_to_mode_defaults,reset_widgets_to_mode_defaults,reset_selection_to_mode_defaults,reset_semantic_to_mode_defaults) and wired existing "Reset section defaults" buttons to these helpers without changing their semantics.color_row(...)more compact by adding a fixedLABEL_WIDTH, setting a minimum row height, and tightening horizontal spacing while preservingcolor_edit_button_srgbaRGBA editing behavior.#[cfg(test)] mod testswith unit tests that coverdefaults_for_mode(...)and regression tests asserting each section-reset helper updates only its intended fields.Testing
cargo fmt --allwhich completed successfully.cargo test theme_settings_dialog -- --nocapturebut the build failed due to a missing system dependency required by a transitive crate (alsa-sysfailed looking upalsa.pcviapkg-config), so the newly added unit tests could not be run in this environment.Codex Task