[slider] Remove extra TalkBack focus targets#4242
Open
atomiks wants to merge 3 commits intomui:masterfrom
Open
[slider] Remove extra TalkBack focus targets#4242atomiks wants to merge 3 commits intomui:masterfrom
atomiks wants to merge 3 commits intomui:masterfrom
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
In Firefox:
Since Firefox is weird either way it's probably OK if it fixes the issue for TalkBack |
Contributor
Author
Not always, only if you've never interacted with another focusable element before. (Same as the issue we had some time ago.) That said, FF supports |
122b4b1 to
22da2cb
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2575
Removing the
tabIndex={-1}from both wrappers makes TalkBack land on the actualinput[type="range"]only, which is the element that correctly handles increase/decrease actionsPreview: https://deploy-preview-4242--base-ui.netlify.app/react/components/slider