Open
Conversation
NoahTheDuke
reviewed
Mar 10, 2026
| no-unbreakable-subs | ||
| (pos? unbroken-subs) | ||
| (can-pay? state side eid card total-cost)) | ||
| (can-pay? state side eid card nil total-cost)) |
Collaborator
There was a problem hiding this comment.
oof, what an annoying footgun. i wonder if we can fix this so it's not possible?
Collaborator
There was a problem hiding this comment.
yes, this can be fixed, somewhat easily i hope:
netrunner/src/clj/game/core/payment.clj
Lines 115 to 117 in a5da8b5
should become:
([state side eid card arg & args]
(let [[title args] (if (string? arg) [arg args] [nil (cons arg args)])
remove-zero-credit-cost (and (= (:source-type eid) :corp-install)
(not (ice? card)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also noticed that the
can-pay?did not work correctly, so I fixed that up.Then I thought maybe we've made that mistake before, so I checked every instance in the code base and found three instances where we had, so I fixed those up too.
I also added tests for lampades on the cost and the whenever.
Closes #8588