Merged
Conversation
Added explicit white background color in the CSS
Owner
|
Thanks! |
Owner
|
It's not quite there though: https://github.com/mpolden/echoip/actions/runs/22526861965/job/65260119814 |
Owner
|
Fixed in 746db5e. |
Closed
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the Github Action to restore automated multi-arch Docker builds, which broke as mentioned in issue #194.
This expects two secrets to be available:
DOCKER_USERNAMEDOCKER_PASSWORDAs well as a single configuration variable:
DOCKER_REPOSITORY(I tested this with lucatnt/echoip and as you can see the image was built correctly for bothamd64andarm64).Due to my noob-ness and the fact that I had forked this repo many years ago, you also see a couple of extra commits that don't belong to this PR, but thankfully the only changed file is actually
.github/ci.yml.