Add method to get screenshot as a Blob instead of base64-encoded string#411
Open
jjhbw wants to merge 4 commits intomozmorris:masterfrom
Open
Add method to get screenshot as a Blob instead of base64-encoded string#411jjhbw wants to merge 4 commits intomozmorris:masterfrom
Blob instead of base64-encoded string#411jjhbw wants to merge 4 commits intomozmorris:masterfrom
Conversation
jjhbw
changed the title
Blob instead of base64-encoded stringBlob instead of base64-encoded string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this very useful lib!
I noticed that encoding bigger screenshots as base64 dataurls takes a lot of CPU. In my testing,
Blobis way faster. If you want to do some downstream processing, directly mapping the canvas to aBlobis also way more memory efficient.Let me know if missed something.