This repository was archived by the owner on Jul 31, 2019. It is now read-only.
[WIP] Fixes #1918, Change Publish popup title when project is Live#2022
Open
rkgupta21 wants to merge 3 commits intomozilla:masterfrom
Open
[WIP] Fixes #1918, Change Publish popup title when project is Live#2022rkgupta21 wants to merge 3 commits intomozilla:masterfrom
rkgupta21 wants to merge 3 commits intomozilla:masterfrom
Conversation
flukeout
previously requested changes
Jul 19, 2017
Contributor
flukeout
left a comment
flukeout
left a comment
There was a problem hiding this comment.
@rkgupta21 For me, in an unpublished project, the Publish popup is trying to show the "projectLive" string, which is incorrect.
Contributor
|
Hey @rkgupta21 - are you still working on this PR? It doesn't look like You could maybe add a class to the popup depending on what state it is in, then show / hide the appropriate elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1918
Added variable to the messages.properties file and added conditions to publish.html
However, I believe that i am not able to access
project.publish_urlin publish.html. It always goes to else statement.