Merged
Conversation
Recent ICU headers don't work with C++14, e.g.
```
In file included from [...]/src/msix/PAL/Applicability/Linux/Applicability.cpp:6:
In file included from /usr/include/unicode/uloc.h:27:
In file included from /usr/include/unicode/uenum.h:25:
/usr/include/unicode/localpointer.h:559:26: error: 'auto' not allowed in template parameter until C++17
559 | template <typename Type, auto closeFunction>
| ^~~~
```
and
```
In file included from [...]/lib/xerces/src/xercesc/util/regx/RangeToken.cpp:40:
In file included from /usr/include/unicode/uset.h:37:
/usr/include/unicode/char16ptr.h:317:10: error: no member named 'is_convertible_v' in namespace 'std'
317 | std::is_convertible_v<T, std::u16string_view>
| ~~~~~^
```
It removed support for old cmake versions as in lib/CMakeLists.txt's `cmake_minimum_required(VERSION 3.4.0 FATAL_ERROR)`
`MINSIGSTKSZ` is not a constant expression anymore, see catchorg/Catch2#2178
Fixes build failure on Linux with newer libstdc++
ncalexan
approved these changes
Mar 11, 2026
Member
|
Nothing worrying me here -- although I can't say I dug deep :) |
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Mar 13, 2026
…-reviewers,ahochheiden Imports changes from mozilla/msix-packaging#1 Differential Revision: https://phabricator.services.mozilla.com/D287420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mozilla-releng/scriptworker-scripts#1383 I'm looking at updating signingscript to run on Debian 13, and hitting errors building msix-packaging due to changes in glibc / libstdc++ / ICU.