Bug 2013658 - Register for multiple tracing events#7202
Conversation
| warn!(target: "third_target", extra=-4, "event message3"); | ||
| info!(target: "third_target", extra=-5, "event message (should be filtered)"); | ||
| // Matches both for first_target and for the min-level, it should only be received once by | ||
| // the sink |
There was a problem hiding this comment.
This is the main reason for this change. On Desktop, when I went to wire up the error-reporting code, I had issues because both the event's target matched and the min-level matched, so we were getting duplicate events and would be reporting each error twice.
bendk
force-pushed
the
push-tywwlwwsrwsu
branch
2 times, most recently
from
e16c768 to
5eb10fd
Compare
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
this looks great! I think you should get a patch up for the breaking changes on desktop before landing this though given how it might end up treading on Ted's toes with the work he's doing around the vendoring.
bendk
force-pushed
the
push-tywwlwwsrwsu
branch
2 times, most recently
from
6dc67bb to
be52154
Compare
Added a new `register_event_sink` method that registers event sinks using the new `EventSinkSpecification` struct. This is general enough that we can use it to implement the older registration methods. This is a breaking change, but Desktop is the only platform that's will be affected. We can resolve the breakage when we do the next vendor.
That makes sense to me, I just put up https://phabricator.services.mozilla.com/D282661 for that. |
2 participants
Added a new
register_event_sinkmethod that registers event sinks using the newEventSinkSpecificationstruct. This is general enough that we can use it to implement the older registration methods.This is a breaking change, but Desktop is the only platform that's will be affected. We can resolve the breakage when we do the next vendor.
Pull Request checklist
[ci full]to the PR title.