fix(orders): Убрать GROUP BY в списке заказов#102
Merged
Conversation
GROUP BY msOrder.id приводил к пустому результату при наличии записей в БД. Все JOIN однозначные (адрес, статус, доставка, оплата), поэтому GROUP BY не нужен.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Исправление пустого списка заказов в менеджере. При 269 заказах в БД таблица отображала пустые строки, но пагинация и статистика работали.
Причина: Условие
GROUP BY msOrder.idвOrdersController::getList()приводило к пустому результату (MySQL ONLY_FULL_GROUP_BY). JOIN‑ы по одному адресу, статусу, доставке и оплате — однозначные, поэтомуGROUP BYне нужен.Решение: Удалён
GROUP BY msOrder.idиз запроса.Тип изменений
Связанные Issues
Closes #(номер issue)
Как это было протестировано?
Конфигурация тестирования:
Скриншоты (если применимо)
Чеклист
Дополнительные заметки
core/components/minishop3/src/Controllers/Api/Manager/OrdersController.phpGROUP BY— единственное изменение, без правок SELECT/JOIN